Checking for missing operands in a binary expression tree

expression-trees java

Question

The purpose of the code is to perform the evaluation of binary expression trees (like the one below).

          (+)
      (*)     (2)
  (+)     (-)
 3   4   5   2

In the code snippet I have, I am confused about how if (root.getLeft() == null || root.getRight() == null) checks for missing operands. If it is a leaf node (operand), will it cause an exception (as the if condition will be true)? I also put the question as a comment in the code near the if-statement.

public float calculateValue(TreeNode root) {
  // Check that the root value is not null
  if (root == null) {
    throw new IllegalArgumentException("Root Node must have a value");
  }
  // If this is a leaf node, it should be a number, so return this
  if (root.getLeft() == null && root.getRight() == null) {
    try {
      return Float.parseFloat(root.getItem().toString()); 
    } catch (NumberFormatException parseError) {
      throw new NumberFormatException("Leaves must be numeric");
    }
  }
  // Validate that we have operands
  if (root.getLeft() == null || root.getRight() == null) {     
    // How does this check for missing operands? If it is a leaf node (operand),
    // will it cause an exception (as the if condition will be true)? 
    throw new IllegalArgumentException("Operator missing operands”);
  }
  // Retrieve the operands
  float leftOperand = calculateValue(root.getLeft());
  float rightOperand = calculateValue(root.getRight());
  // Extract the operator
  String operatorString = root.getItem().toString();
  if (operatorString.length() > 1) {
    throw new IllegalArgumentException("Invalid operation!");
  }
  char operator = operatorString.charAt(0);
  // Evaluate the operation
1
0
1/7/2017 6:06:00 PM

Fastest Entity Framework Extensions

Bulk Insert
Bulk Delete
Bulk Update
Bulk Merge

Accepted Answer

Below I've got your code up to that if-statement with the comments removed:

if (root == null) {
    throw new IllegalArgumentException("Root Node must have a value");
}

if (root.getLeft() == null && root.getRight() == null) {
    try {
       return Float.parseFloat(root.getItem().toString()); 
    } catch (NumberFormatException parseError) {
       throw new NumberFormatException("Leaves must be numeric");
    }
}

if (root.getLeft() == null || root.getRight() == null) {     
    throw new IllegalArgumentException("Operator missing operands");
}

To answer your question, note that in the case of a leaf node, the second if-statement is true. Thus, it will go through that try-catch and never even execute if (root.getLeft() == null || root.getRight() == null).

0
6/18/2014 12:05:25 AM

Related Questions

An expression tree may be sent as a parameter to another expression tree.

I have two expression trees defined like this:...private Expression<Func<TEntity, TPropertyResult>> PropertyAccessor { get; set; } ...and...private Expression<Func<TPropertyResult, bool>> TestExpression { get; set; } ...I need to create a new expression tree that will result in the equivalent of:...var expression = p => this.TestExpression(this.Pro...
c# expression-trees lambda
asked by Pierre-Alain Vigeant

How may value types in LINQ/lambdas/expression trees be checked at compile time?

I'm using the following code to set ...Control... properties in a thread-safe manner:...private delegate void SetPropertyThreadSafeDelegate<TPropertyType>(Control @this, Expression<Func<TPropertyType>> property, TPropertyType value); public static void SetPropertyThreadSafe<TPropertyType>(this Control @this, Expression<Func<TPropertyType>> propert...
.net c# expression-trees lambda linq
asked by Ian Kemp

In an Expression Tree, have you checked type-cast?

I am using Expression to create a little bit of dynamically-generated code. My solution works, except for one feature: I want to do a checked type-cast, where TypeCastException is thrown if the cast fails....I have found Expression.TypeAs(), which does the type conversion, but it returns null, rather than throwing, when the cast fails....Is there a...
c# expression-trees
asked by PeteAC

Generate a Binary Expression Tree

Could someone explain how to build a binary expression tree....For example I have a string ...2*(1+(2*1));... How to convert this into a binary expression tree.... * | \ | \ 2 + |\ 1 * |\ 2 1
algorithm expression-trees
asked by user1110839

Building an expression tree using a stack and a binary tree c

I am given an arithmetic formula containing operators +, -, *, / and parentheses (which might or might not change the natural precedence of operators). An example would be the following one: a / b + f – (c + d) * e – a * c. and I am asked to use a stack (implemented as a linked list) in order to keep track of the operands and the operators: an...
binary-tree c expression-trees stack
asked by user1680944

Binary expression tree C++

I have a little problem. I'm trying to add a mathematical expression to a binary tree but I can't understand the algorithm. Here it is:...If the current token is a '(': Add a new node as the left child of the current node, and descend to the left child. If the current token is in the list ['+','-','/','*']: Set the root value of the current nod...
c++ expression-trees
asked by Sinan Zikri

Best way to check if value is null in Expression Tree

What is the best way to check if constant is null in Expression Trees?...// Method to call (Regex.IsMatch) MethodInfo isMatchMethod = typeof(Regex).GetMethod("IsMatch", new[] { typeof(string), typeof(string), typeof(RegexOptions) }); // The member you want to evaluate: (x => x.<property_name>) var member = Expression.Property(param, propertyName);...
c# expression-trees
asked by Vitone

C++ Binary Expression Tree: How do I print an infix expression with appropriate parentheses?

Right now I have this simple print algorithm that prints perfect parentheses. The problem is, the parentheses aren't always necessary, and I need to figure out how to not print them when they aren't needed....My current function:...void printIn(Node* t){ if(t!= NULL) { if(isleafNode(t)) cout << t->element; else { cout...
binary-tree c++ expression-trees tree
asked by user5600232

How do I implement a binary expression tree in Java?

I am struggling to create a binary expression tree, and haven't found exactly what I'm looking for online.
binary-tree expression-trees java
asked by ZapMeDo

C# Null check in expression trees

I have a class called User in which there is a field wherein the user can send any data type. Currently we are sending int, double and string....Since the field is dynamic meaning the field name could be anything we are using expression trees. The issue I am facing now is if the field is null in the select query or the field value then it throws er...
c# expression-trees
asked by Anil Jain

Fastest Entity Framework Extensions

Bulk Insert
Bulk Delete
Bulk Update
Bulk Merge
View more on Stack Overflow

Prime Library

Performance

Expression Evaluator

More Projects...
Licensed under: CC-BY-SA with attribution
Not affiliated with Stack Overflow
Licensed under: CC-BY-SA with attribution
Not affiliated with Stack Overflow