Can't build lambda Expression with unknown type of a property

c# entity-framework expression-trees linq

Question

I am building a helper method that returns an expression based on a property that could be used in an orderby or where, etc. in a linq to entities operation.

I won't know the type of the property upfront, so I have declared it as object and dynamic and have also tried to use Expression.Convert but it will not work for non string typed properties.

The current property type that is not a string that I'm working with is int? and the error I get is

Expression of type 'System.Nullable`1[System.Int32]' cannot be used for return type 'System.Object';

Code:

var param = Expression.Parameter(typeof(Employee), "x");
MemberExpression propExp = Expression.Property(param, "somePropertyName");
Expression.Lambda<Func<Employee, object>>(propExpression, param);

AS I said, I've used object and dynamic in line above with same results. I've also tried to convert it to the right type but that doesn't work:

Expression conversion = Expression.Convert(propExp, ((PropertyInfo)propExp.Member).PropertyType)

While I'm in debug mode and I try this, Expression.Lambda(conversiona, param), it seems to work

{x => Convert(x.EmployeeNo)}
Body: {Convert(x.EmployeeNo)}
CanReduce: false
DebugView: ".Lambda #Lambda1<System.Func`2[xx.DomainModel.Entities.Employee,System.Nullable`1[System.Int32]]>(xx.DomainModel.Entities.Employee $x)\r\n{\r\n    (System.Nullable`1[System.Int32])$x.EmployeeNo\r\n}"
Name: null
NodeType: Lambda
Parameters: Count = 1
ReturnType: {Name = "Nullable`1" FullName = "System.Nullable`1[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]"}
TailCall: false
Type: {Name = "Func`2" FullName = "System.Func`2[[xx.DomainModel.Entities.Employee, Fng.Facts.DomainModel, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null],[System.Nullable`1[[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]"}

...but when I use it in an orderby I get

error CS1503: Argument 2: cannot convert from 'System.Linq.Expressions.LambdaExpression' to 'string'

I thought that maybe I needed to dynamically build the Expression.Lambda using the correct type as I inspect it but haven't tried that yet

Thanks for any help

1
1
11/13/2016 10:34:28 AM

Fastest Entity Framework Extensions

Bulk Insert
Bulk Delete
Bulk Update
Bulk Merge

Popular Answer

Convert it to object by 

Expression conversion = Expression.Convert(propExp, typeof(object))

That should be ok to be returned, but then you will have to deal with these converts on the other side, where you do the Orderby.

    private IQueryable<T> AddOrderBy<T>(IQueryable<T> query, Expression<Func<T, object>> orderByProperty, bool isAscending, bool isFirst)
{
    Expression<Func<IOrderedQueryable<int>, IQueryable<int>>> methodDef = isAscending 
        ? (isFirst ? (Expression<Func<IOrderedQueryable<int>, IQueryable<int>>>)(q => q.OrderBy(x => x)) : (Expression<Func<IOrderedQueryable<int>, IQueryable<int>>>)(q => q.ThenBy(x => x)))
        : (isFirst ? (Expression<Func<IOrderedQueryable<int>, IQueryable<int>>>)(q => q.OrderByDescending(x => x)) : (Expression<Func<IOrderedQueryable<int>, IQueryable<int>>>)(q => q.ThenByDescending(x => x)));

    // get the property type
    var propExpression = orderByProperty.Body.NodeType == ExpressionType.Convert && orderByProperty.Body.Type == typeof(object)
        ? (LambdaExpression)Expression.Lambda(((UnaryExpression)orderByProperty.Body).Operand, orderByProperty.Parameters)
        : orderByProperty;

    var methodInfo = ((MethodCallExpression)methodDef.Body).Method.GetGenericMethodDefinition().MakeGenericMethod(typeof(T), propExpression.Body.Type);
    return (IQueryable<T>)methodInfo.Invoke(null, new object[]{query, propExpression});
}
1
11/13/2016 9:19:44 PM

Related Questions

When creating binary lambda expressions, the lambda parameter is not in scope.

You need to reuse the same parameter object. So where you've got:... MemberExpression left = Expression.Property (Expression.Parameter(typeof(OtherType), "para"), property); ...it should be:... MemberExpression left = Expression.Property(para, property); ...I know it would make sense for them to match by name, but that's just not the way it w...
c# expression-trees lambda
asked by Jon Skeet

Why can't I manually generate the same Expression Tree that my straight lambda does?

Check the documentation: the '+' operator is actually not defined in the ...String... class. I guess the compiler just knows it means "concatenate the strings", and it transforms it into a call to ...Concat.... So when you call ...Expression.Add..., you need to specify the method that implements the operation (in that case the ...String.Concat... m...
c# expression-trees lambda
asked by Thomas Levesque

Scoping resolution - expression tree - compile inner lambda in outer lambda

I am creating expression tree and there is a situation where I need to create one lambda in another lambda and store inner one in a class and add that class in expression tree. This is simple example of what I am trying to do (this code does not compile):...using System; using System.Collections.Generic; using System.Linq; using System.Text; using ...
c# dynamic-language-runtime expression-trees scope
asked by del-boy

Building an OrderBy Lambda expression based on child entity's property

I'm trying to generate a LINQ ...OrderBy... clause using lambda expressions with an input of the column name of an entity as a string (in the "sortOn" variable below)....The code below works fine for a sortOn value like "Code" generating the lambda ...p => p.Code ...But I would also like to sort on a child entity, where the lambda might be ...p => ...
c# expression-trees lambda linq
asked by Appetere

Unable to cast object of type 'System.Linq.Expressions.UnaryExpression' to type 'System.Linq.Expressions.MemberExpression'

I created a ...method in C#... to get methodname...public string GetCorrectPropertyName<T>(Expression<Func<T, string>> expression) { return ((MemberExpression)expression.Body).Member.Name; // Failure Point } ...and calling it as...string lcl_name = false; public string Name { get { return lcl_name ; } set { lcl_name = value; ...
c# exception-handling expression-trees linq
asked by Nikhil Agrawal

Build a nested lambda Expression Tree for an Entity Framework Many to Many relationship?

Here is the solution that I have come up with, my biggest help came from ...Calling a Method from an Expression... The biggest thing to over come was to create a generic "Any" method. The rest was just chaining the calls together....private MethodCallExpression BuiltMethodCall(IQueryable _query, string CustTypeID, Type _ParentObjType, Type _ChildOb...
.net entity-framework expression-trees linq many-to-many
asked by Brian Tax

Expression.Convert type for Expression.Property

I'm trying to convert a Parameter expression and having trouble with converting to value types. Below is a sample of my code:...public static MemberExpression ConvertToType(ParameterExpression sourceParameter, PropertyInfo propertyInfo, TypeCode typeCode) ...
c# expression-trees lambda
asked by will

Using lambda expression to get property OR type name

How can I adapt the method below to work when the lambda expression refers to the actual instance itself?...e.g. instead of...x => x.Name ...the expression is...x => x ...so if I had some class "Car" I could return the string "Car" instead of only being able to operate on its properties (e.g. Car.Colour)...The method:...public static string GetMemb...
c# expression-trees lambda
asked by Mathew

how to build expression tree for multilevel property/child property

You have to create nested property expression as you're looking for nested property....Expression bExpression = Expression.Property(Expression.Constant(obj), "B"); Expression numExpression = Expression.Property(bExpression, "num"); Console.WriteLine(Expression.Lambda<Func<int>>(numExpression).Compile()());//Prints 5
c# expression expression-trees
asked by Sriram Sakthivel

How do I create a lambda expression using return value from another lambda expression?

You want to grab the parameter off the lambda and use the body as the expression. You aren't using it as a lambda at all - you are picking the expression tree and parameters out of the lambda.... // create // ent => exp(ent).Contains(s) public static IQueryable<T> WhereContains<T>(this IQueryable<T> qry, Expression<Func<T, string>> exp,...
c# entity-framework expression-trees lambda linq-expressions
asked by TheSoftwareJedi

Fastest Entity Framework Extensions

Bulk Insert
Bulk Delete
Bulk Update
Bulk Merge
View more on Stack Overflow

Prime Library

Performance

Expression Evaluator

More Projects...
Licensed under: CC-BY-SA with attribution
Not affiliated with Stack Overflow
Licensed under: CC-BY-SA with attribution
Not affiliated with Stack Overflow